updating the code to work with python 3.12#18
Conversation
|
|
||
| # Pyre type checker | ||
| .pyre/ | ||
| .lh |
There was a problem hiding this comment.
It's pretty harmless just in the .gitignore, but what is this for? I think this can be removed.
There was a problem hiding this comment.
This whole webapp doesn't have any external services, so I don't see a need for it to have a docker compose. I appreciate the Dockerfile though!
| Flask==1.1.2 | ||
| Flask-SocketIO==5.0.1 | ||
| greenlet==1.0.0 | ||
| greenlet |
There was a problem hiding this comment.
This dependency (and many others) is out of date, but I don't want to unpin them.
| if __name__ == '__main__': | ||
| socketio.run(app, debug=True, host=u'0.0.0.0') | ||
| if __name__ == "__main__": | ||
| socketio.run(app, debug=False, host="0.0.0.0") |
There was a problem hiding this comment.
| socketio.run(app, debug=False, host="0.0.0.0") | |
| socketio.run(app, debug=True, host="0.0.0.0") |
This should all probably be reading in parameters from a config file or something, but let's keep the original default value.
| COPY requirements.txt ./ | ||
| RUN python3 -m pip install --no-cache-dir -r requirements.txt | ||
|
|
||
| COPY . . |
There was a problem hiding this comment.
You can just use this last COPY you don't need both. It may be easier for development to save the cached layer for later, but it doesn't need to be that way on the repo.
|
Thanks, again, for all your help. I've merged in your changes, with my comments in #23. |
2 participants
No description provided.